kicad-developers team mailing list archive

[Jean-Samuel Reynaud <js.reynaud@xxxxxxxxx>]

 Oups...

Attached now...

Le 27/03/2014 19:38, Nick Østergaard a écrit :
> No patch attached.
>
>
> 2014-03-27 19:36 GMT+01:00 Jean-Samuel Reynaud <js.reynaud@xxxxxxxxx
> <mailto:js.reynaud@xxxxxxxxx>>:
>
>     Hi All,
>
>     Please find attached a patch to fix the
>     "pcbnewFinishPythonScripting();"
>     compilation issue.
>     It was just a mismatch between method signature in
>     scripting/python_scripting.cpp and scripting/python_scripting.h
>
>     Regards,
>     Le 20/03/2014 07:58, Dick Hollenbeck a écrit :
>     > I committed milestone A) this evening.
>     >
>     > I will watch my email tomorrow for problem reports and calls for
>     help.
>     >
>     > I also tagged the product branch revision just preceding the A)
>     commit as "pre-kiway".
>     >
>     > So if you need to build that version, you can check it out using
>     the tag.
>     >
>     > bzr co -rtag:pre-kiway  lp:kicad
>     >
>     > or something like that.
>     >
>     > -----------------------
>     >
>     > I was out of breath, put forth a super human effort at the end
>     to outrun the deluge of
>     > inbound commits, many of which were barely going to merge or
>     weren't going to merge.
>     >
>     > Let me assure you that this commit is going to be unique in the
>     history of the project.
>     > So please do not be dismayed if some things work differently.
>     >
>     > I am here to help, and eventually the pond ripples will settle down.
>     >
>     > There is one link issue outstanding if you are building for
>     wxpython scripting.  You can
>     > either find a fix or comment out
>     >
>     >       pcbnewFinishPythonScripting();
>     >
>     > near line 479 of pcbnew/pcbnew.cpp.
>     >
>     > A fix is preferred, and it is something in CMakeLists.txt for
>     pcbnew.  But to be honest, I
>     > have python scripting work scheduled for milestone C), not A) or
>     B).  So that particular
>     > topic will not be my main priority until later.  Other problems
>     you may have I intend to
>     > help with diligently.
>     >
>     > When you install, you will be installing tandem binaries now for
>     the main program modules.
>     >  So there will be both a
>     >
>     > 1) pcbnew (exe), and
>     > 2) _pcbnew.kiface
>     >
>     > binary files.
>     >
>     > I suggest you run using the Debug build for awhile.  This is
>     necessary to smoke out any
>     > dialogs which are not derived from DIALOG_SHIM.  There still
>     could be some, and Debug
>     > build will find them.  Otherwise there Kiway() window function
>     will return NULL and you'll
>     > get a crash.  wxformbuilder can be used to stuff DIALOG_SHIM
>     under any dialog windows that
>     > turn up this way.
>     >
>     >
>     > Dick
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/%7Ekicad-developers>
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/%7Ekicad-developers>
>     > More help   : https://help.launchpad.net/ListHelp
>
>
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/%7Ekicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/%7Ekicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>
>

=== modified file 'pcbnew/pcbnew.cpp'
--- pcbnew/pcbnew.cpp	2014-03-22 08:28:39 +0000
+++ pcbnew/pcbnew.cpp	2014-03-27 18:32:32 +0000
@@ -483,9 +483,7 @@
     // wxPython will do its own cleanup as part of that process.
     // This should only be called if python was setup correctly.
 
-/* bring this in, but without a linker error:
     pcbnewFinishPythonScripting();
-*/
 
 #endif
 }

=== modified file 'scripting/python_scripting.cpp'
--- scripting/python_scripting.cpp	2014-02-21 10:05:28 +0000
+++ scripting/python_scripting.cpp	2014-03-27 18:27:25 +0000
@@ -172,7 +172,7 @@
 }
 
 
-void pcbnewFinishPythonScripting( char )
+void pcbnewFinishPythonScripting( void )
 {
 #ifdef KICAD_SCRIPTING_WXPYTHON
     wxPyEndAllowThreads( g_PythonMainTState );