kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

Hello,

I see that Nick proposed a patch, which saves someone about 30 seconds and costs me an
unknown amount of time to backtrack into the patch history, and verify that it does not
break anything, considering we are using dummy repos all over the place.


Its not worth it to me, just set bzr whoami and have a genuine bzr installation, not a
half ass-ed one.


Dick



On 04/06/2014 04:06 PM, Nick Østergaard wrote:
> Hello
> 
> I see that Dick now merged the no lp login install script - great.
> That also solved the step 9 not completing (at least for me).
> 
> But the script still requires that the bzr whoami is set when it tries
> to build boost. My suggestion to fix this is attached.
> 
> It removed the bzr whoami check in the install script, because that is
> not needed anymore, since we now use https to dowload the sources and
> that I patched the download_boost.cmake to use some dummy bzr whoami
> information (sot it is always set here). This is overrides whatever
> bzr whoami that is set in that step, but I guess that is fine, because
> this step is not to be comitted anywhere else than locally.
> 
> Regards
> Nick Østergaard
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>