← Back to team overview

kicad-developers team mailing list archive

Re: modified flags in TRACKS_CLEANER::clean_segments

 

Le 13/04/2014 15:18, Lorenzo Marcantonio a écrit :
> Looking in some refactoring of these huge functions. Missing a lot
> nested function from functional languages (even Pascal has these:P)...
> The non-structured use of the continue statement makes it somewhat
> difficult to follow but everyone has his programming style:P
> 
> Anyway: the modified flag returned at the end signals the caller that
> undo history has to be reset and other things need to be reset too. 
> 
> Shouldn't it be set in the initial 'delete null segments' loop too?
> 

Yes, it should be set.

-- 
Jean-Pierre CHARRAS


References