← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix osx_fixbundle.sh for building on OSX

 

Le 29/05/2014 19:11, Bernhard Stegmaier a écrit :
> Hi,
> 
> oh, sorry for that… I have some other small changes in my local repository.
> I guess that's why.

I just need to be sure there was no mistake.
A warning is not a problem, but only if it is expected.

I committed your patch.

> 
> General question:
> If I push my local repository to my own launchpad branch, is it then
> more easy to pull a fix from there even if I have some (unrelated)
> changes in my branch?
> Otherwise I would always have to maintain changes in 2 branches before
> sending a patch to ML...
> 
> 
> Regards,
> Bernhard

Avoiding to maintain 2 branches is better.

If you are thinking a patch can create issues, you just can have a
(pristine) copy of launchpad kicad branch, and see what happens when
applying the patch to this branch.

If there is a warning, just say "when applying my patch, you could have
a warning, but this is OK".


-- 
Jean-Pierre CHARRAS


Follow ups

References