kicad-developers team mailing list archive

[Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx>]

Of course x >=0 … or x < 0… :)

Some of the unused variables really don’t seem to be used… e.g. in pcb_calculator classes, where I really guess no OSX dependencies and don’t see any #define around...


Regards,
Bernhard

On 02.06.2014, at 20:04, Lorenzo Marcantonio <l.marcantonio@xxxxxxxxxxxx> wrote:

> On Mon, Jun 02, 2014 at 07:52:52PM +0200, Bernhard Stegmaier wrote:
>> Removes unneeded checks (e.g., a check “x > 0” for an "unsigned x” is pretty obsolete).
> 
> x >= 0, I hope :D
> 
> As for unused variable probably it's only a Mac thing (or clang has
> a better flow analyzer than g++), I don't see any with -O3 -Wall on
> linux
> 
> -- 
> Lorenzo Marcantonio
> Logos Srl
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp