kicad-developers team mailing list archive

[Thiadmer Riemersma <thiadmer.riemersma@xxxxxxxxx>]

Hello everyone,

Attached is a tiny patch for a bug in the option "One file per layer" in
the dialog "Export SVG file" in pcbnew. In the earlier version, when
checking this option, you would get a set of files (one for each selected
layer) and each file would contain all layers superimposed. Alternatively,
if you selected the option "All in one file", you would get a single file,
with just one layer. This was due to a simple inversion of the "then" and
"else" clauses of a conditional expression. The patch corrects this.

Question: I am considering to add the option "Opaque white background" to
the dialog, in order to draw a layer on white. Right now, the background is
transparent. Would a patch that implements this have a chance to get
accepted?

Regards,
Thiadmer Riemersma

=== modified file 'pcbnew/dialogs/dialog_SVG_print.cpp'
--- pcbnew/dialogs/dialog_SVG_print.cpp	2014-06-30 06:44:46 +0000
+++ pcbnew/dialogs/dialog_SVG_print.cpp	2014-07-23 11:11:43 +0000
@@ -302,7 +302,7 @@
 
         BuildPlotFileName( &fn, outputDir.GetPath(), suffix, SVGFileExtension );
 
-        m_printMaskLayer = aOnlyOneFile ? LSET( layer ) : all_selected;
+        m_printMaskLayer = aOnlyOneFile ? all_selected : LSET( layer );
 
         if( m_PrintBoardEdgesCtrl->IsChecked() )
             m_printMaskLayer.set( Edge_Cuts );