kicad-developers team mailing list archive

[Mário Luzeiro <mrluzeiro@xxxxx>]

Sorry I found that too last night but I didnt had time to upload a fix.

Would you (merger masters) would like to update my path attached in the trunk?
it fixes the X3D missing color issue and add some small fixes and improvements.
It added the capability to parse diffuse color from x3d model and use it.
Code style reviewed.

Thanks!
Mario Luzeiro
________________________________________
From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx] on behalf of Andrew Zonenberg [azonenberg@xxxxxxxxxxxxxxx]
Sent: 01 August 2014 21:42
To: kicad-developers@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Kicad-developers] Segfault in X3D module parser (build 5041, did not happen in 5034) [PATCH]

The attached patch causes the model to load properly on my machine. It
adds a check to disable loading color information if no color nodes were
found.

On Fri, 2014-08-01 at 15:29 -0400, Andrew Zonenberg wrote:
> When loading this model:
> http://colossus.cs.rpi.edu/~azonenberg/downloads/molex-1051561008.x3d
>
> I get a crash in the X3D model parser.
>
> It appears to be due to a null dereference accessing color[0] since
> color has a size of zero and the internal array is null.

Attachment: 3d-viewer_updates_merged.diff
Description: 3d-viewer_updates_merged.diff