← Back to team overview

kicad-developers team mailing list archive

Re: version info does not get updated

 


Le 03/09/2014 20:08, Wayne Stambaugh a écrit :
On 9/3/2014 8:08 AM, yann jautard wrote:
Le 03/09/2014 12:32, yann jautard a écrit :
Le 02/09/2014 18:24, Wayne Stambaugh a écrit :
I have this on my list of things to look at.  It should be possible to
get CMake to generate make files that compare the source repo version
against the version.h file and recreate it as required every time make
is run.  Currently, the only time version.h gets updated is when the
CMake files are modified or make rebuild_cache is run.


I checked it right now : I added "make rebuild-dep" to beginning of
the build process in kicad-install.sh. Running it with a kicad install
witj not up to date version info results in rebuilding only
build_version.cpp and relinking all parts that have a user interface.
Rebuilding the dependencies is not what you want to do if all you are
trying to do is update the version string.

(...)

yes of course that was rebuild_cache, I made a mistake writing the mail.

So as you said you want to get Cmake to compare the version with the one in the file, I'm pretty sure it is not necessary. Just calling make rebuild_cache before make do the job pretty well.

I think the kicad-install.sh script could be updated to add this make rebuild_cache step before compilation. That way you will be sure version is updated each time, and bug reports by guys like me will be accurate.


(...)
I noticed also that the build step is done twice : the first time when
compiling, then it is done again before installing. Without compiling
anything more of course because it was already done, but that take a lot
of time.
This should not happen.  Once make is called and kicad is completely
build, calling make install will check to make sure everything is built
before installing.

Yes maybe this is what happens, just checking.
But "just checking" is quite long.
When calling "make install" directly, it checks, and as it is not already built, it build and then install, all in one single step. Faster on little systems.







Follow ups

References