kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 9/4/2014 9:44 AM, Moses McKnight wrote:
> Interesting!  I don't have a .SchematicFrame file and haven't seen one,
> but looking at the code I see that eeschema tries to read hotkey configs
> from that file:  ReadHotkeyConfig( wxT("SchematicFrame"),
> s_Eeschema_Hokeys_Descr );
> 
> Anyhow, the culprit is in a couple places in hotkeys_basic.cpp where it
> uses wxConfig instead of the new function GetNewConfig()
> 
> I fixed that now, and did a grep for other uses of wxConfig and could
> not find any more.  So I think I've caught all of those now.

I'm not sure how this slipped through the cracks but it is definitely a
bug.  Good catch.  I'll commit your patch as soon as I can.  I have a
few comments on your code formatting.  I found some trailing white space
which looks like you or your editor added an extra tab.  The wxT("")
definitions should be wxT( "" ).  The doxygen comment in the header
should include the function name.  I'll make these changes when I commit
the patch.  Thank you for contributing to KiCad.

> 
> I also changed the message about the fp-lib-table in the home folder to
> "...in the kicad config folder..."
> 
> As for the "\n" separators, that is part of the hotkey setting format
> itself, and is the way it should be.
> 
> Moses
> 
> On 09/04/2014 12:45 AM, yann jautard wrote:
>> I just tested your patch on Ubuntu, works fine.
>>
>> But I noticed one file is still stored on home dir : the hotkey config
>> file
>> ~/.SchematicFrame
>>
>> I think it should be relocated too.
>>
>> Regarding this file, I think there is a formatting error in it : it is
>> composed
>> of one single line with plain text "\n" as item separators. I guess
>> that these
>> should be real carriage return instead of writing them down.
>>
>> I can propose a patch to correct this if needed.
>>
>>
>>
>> Le 03/09/2014 22:40, Moses McKnight a écrit :
>>> Ok, the previous patch actually put the files in
>>> ~/Library/Preferences/.config/kicad on OSX, so I added a check for
>>> __WXMAC__
>>> so it does not add the .config directory on OSX. I also did a little
>>> cleanup
>>> on the patch - mainly removed the check for OS/2 which I'm pretty
>>> sure is not
>>> needed for kicad!
>>>
>>> nullset on IRC who did some testing did say he thinks the
>>> ~/Library/Preferences/kicad location is fine for the config files.
>>>
>>> Moses
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>