kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #14946
Re: Finally!
No hurry. Let me know when you have it sorted out. Please send me a
patch so I can verify it on msys2.
Thanks,
Wayne
On 10/4/2014 7:12 PM, Brian Sidebotham wrote:
> Hi Wayne, I can't check right now, but I'm sure it is to find
> python-a-mingw-us for kicad-winbuilder. I expect the answer is to remove
> the custom findpython cmake module and replace it with a
> findpythonamingwus module instead.
>
> Please let me introduce the latter before we remove the former; Sorry it
> caused you grief.
>
> I'm away from my keyboard at the moment so I'll have a look at this
> tomorrow when I'm back at the keyboard.
>
> Best Regards,
>
> Brian.
>
> On 4 Oct 2014 23:32, "Wayne Stambaugh" <stambaughw@xxxxxxxxxxx
> <mailto:stambaughw@xxxxxxxxxxx>> wrote:
>
> Thanks for the input. I give Brian and chance to reply. It may have
> been something just for the kicad-winbuilder so I may have to find an
> alternate solution that works in both cases.
>
> On 10/4/2014 6:21 PM, Blair Bonnett wrote:
> > On 5 October 2014 10:09, Wayne Stambaugh <stambaughw@xxxxxxxxxxx
> <mailto:stambaughw@xxxxxxxxxxx>
> > <mailto:stambaughw@xxxxxxxxxxx <mailto:stambaughw@xxxxxxxxxxx>>>
> wrote:
> >
> >> On that note, I had to remove our custom FindPythonLib.cmake in
> order to
> >
> >> get it to work properly. There are some questionable if( MINGW )
> blocks
> >
> >> in our custom version that don't make sense to me. Would who ever
> >
> >> modified the stock CMake version and added to our source please
> let me
> >
> >> know why these changes are necessary so I can figure out a
> solution. If
> >
> >> I don't hear from you over the next few days, I'm removing our custom
> >> version of FindPythonLib.cmake.
> >
> > Hi Wayne,
> >
> > Not being a Windows user I can't speculate as to the need for the
> > customisation, but CMakeModules/FindPythonInterp.cmake
> > and CMakeModules/FindPythonLibs.cmake were added by Brian
> Sidebotham in
> > rev 4268 [1] and haven't been changed since [2]. It might be that the
> > stock file which ships with newer versions of CMake has been
> improved so
> > that the custom one isn't needed anymore.
> >
> > Nice work getting this working.
> >
> > Blair
> >
> >
> > [1]
> >
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/revision/4268
> > [2]
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/changes?filter_file_id=findpythonlibs.cmake-20130804200613-h34h9txoq48ewiaw-4
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References