← Back to team overview

kicad-developers team mailing list archive

Re: Code cleaning.

 

JP,

Thank you for taking care of this.  I appreciate it.

Best Regards,

Wayne

On 10/29/2014 8:24 AM, jp charras wrote:
> Le 28/10/2014 20:59, Wayne Stambaugh a écrit :
>> I've been adding missing license statements to our source code and have
>> run into a few issues along the way.
> 
> Thanks.
> 
>>
>> PolyLine.h and PolyLine.cpp have this comment:
>>
>> // PolyLine.cpp ... implementation of CPolyLine class from FreePCB.
>>
>> at the top of the file with no other license information.  Whoever added
>> this file please add the FreePCB license for this code so we are
>> compliant.  I don't know what the FreePCB license is so I hope this is
>> not an issue.  I believe the GPL does not allow for unlicensed source files.
> 
> I added the license information to these files in rev 5235.
> 
> There is no license issue: FreePCB is released under the GNU General
> Public License V2 or later.
> 
>>
>> I noticed that the Python scripts in pcbnew/scripting/examples do not
>> get installed.  Is there a reason we are not installing these files
>> along with the rest of kicad?
>>
>> The kiface libraries are getting installed in ${prefix}/bin on Unix.
>> Aren't they supposed to be in ${prefix}/lib?  Maybe our packagers are
>> running a script to move them to ${prefix}/lib but I think we should be
>> following convention here.
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 




References