kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH] Rename instances of "module" to "footprint" for consistency
In the future, please send patches as attachments rather than in-line.
It makes it easier for me view and apply them. My mail client is not a
very good diff file viewer.
On 10/29/2014 12:05 PM, Marco Ciampa wrote:
> On Wed, Oct 08, 2014 at 02:37:40AM -0400, Mark Roszko wrote:
>> So from what I remember, Kicad used to call alot of pcb footprints as
>> "modules". Sometimes it was "module", other times "footprint module"
>> and now "footprint". Footprint seems to have picked up in usage so
>> let's use it everywhere!
>> Right now new users just get confused and its a popular compliant. I
>> don't blame them, the inconsistency is annoying.
> I see that in all this source the reference is on a "module" so I think
> the programmer got tricked by this name and used it also for the message
> strings, despite the source file name explicitely refers to "footprints"
> and not "modules".
> Please apply this patch...
> bzr diff
> === modified file 'pcbnew/autorouter/auto_place_footprints.cpp'
> --- pcbnew/autorouter/auto_place_footprints.cpp 2014-10-06 01:18:24 +0000
> +++ pcbnew/autorouter/auto_place_footprints.cpp 2014-10-29 15:54:50 +0000
> @@ -278,7 +278,7 @@
> while( ( Module = PickModule( this, DC ) ) != NULL )
> // Display some info about activity, module placement can take a while:
> - msg.Printf( _( "Place module %d of %d" ), cnt, moduleCount );
> + msg.Printf( _( "Place footprint %d of %d" ), cnt, moduleCount );
> SetStatusText( msg );
> double initialOrient = Module->GetOrientation();
> === modified file 'pcbnew/autorouter/spread_footprints.cpp'
> --- pcbnew/autorouter/spread_footprints.cpp 2014-03-05 17:57:13 +0000
> +++ pcbnew/autorouter/spread_footprints.cpp 2014-10-29 15:52:07 +0000
> @@ -174,7 +174,7 @@
> if( aFootprintsOutsideBoardOnly && !edgesExist )
> DisplayError( this,
> - _( "Could not automatically place modules. No board outlines detected." ) );
> + _( "Could not automatically place footprints. No board outlines detected." ) );