← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] IsSingleLine() assertions failing in eeschema, pcbnew, and PCB calculator

 

On 4 November 2014 04:32, Lorenzo Marcantonio <l.marcantonio@xxxxxxxxxxxx>
wrote:
>
> On Tue, Nov 04, 2014 at 12:07:51AM +1300, Blair Bonnett wrote:
> > The source for all of these is in files generated by wxFormBuilder. The
> > attached patch fixes this by removing the call from the relevant
*_base.cpp
> > files and changing the maxlength property to be empty rather than zero
in
> > the corresponding .fpb files.
>
> I'd say that a better way to test if it works is to patch the fpb files
> and then reload them in the current formbuilder and regenerating the
> base files; otherwise the effort is wasted...
>
> Could be a bug in formbuilder, too.

I've just run a couple of my patched .fpb files through the wxFormBuilder
3.5.0beta and the generated C++ base files are identical to my patched
versions. Additionally, I created a quick new project and text boxes now
have the maxlength property set to empty rather than zero, and the
generated C++ is correct. So this problem *shouldn't* occur with the latest
version of wxFormBuilder, though I'm not sure (a) in which version it was
fixed, or (b) what version is suggested for KiCad development.

Follow ups

References