kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

Sorry it took so long.  I committed this patch in product branch r5256.
 Thank you for your contribution to KiCad.  Did you pulling this patch
from wxWidgets trunk or did you fix it yourself?  If you fixed a
wxWidgets bug, please open a bug report on the wxWidgets bug tracker so
we don't have to maintain this patch forever.

On 10/23/2014 11:12 PM, Garth Corral wrote:
> 
> Okay, the patch is attached.  It’s very small—about 4 lines each in two files—and applies cleanly to 3.0.0 through 3.0.2.
> 
> I think that Bernhard said he was able to observe this issue on a vanilla build of recent sources.  Perhaps he can verify whether this resolves the issue and decide whether to include it with the other patches.  In the mean time I’ll see if I can dig up a trac bug that goes with this.
> 
> 
> Garth
> 
> 
> 
> 
> 
> 
> 
> On Oct 23, 2014, at 7:26 AM, Wayne Stambaugh <stambaughw@xxxxxxxxxxx> wrote:
> 
>> On 10/22/2014 2:39 PM, Garth Corral wrote:
>>>
>>> Hi all,
>>>
>>> I have a set of changes that I've been maintaining locally for my kicad builds that add support for trackpad gestures for panning and zooming on OSX, and generally improving the usabilitiy of a trackpad or mousewheel with kicad on this platform.
>>>
>>> In trying to clean these up to be less platform specific, I ran into an issue with wxWidgets on (at least) OS X where a wxScrolledWindow processes scrollwin events no matter what, even if the event is already processed by client code. This can cause panning to happen in both directions simultaneously when using the mousewheel on OS X.   I beat my head against this for a bit before I realized it was deep in a wxWidgets handler and not kicad.  Fortunately there’s a simple fix for this sitting on wxWidgets trunk that I applied and it does resolve the issue.  This affects the current product series on OS X.  Does this not impact Linux and Windows?
>>>
>>> Since we’re applying patches for OS X anyway, seems like this fix should be included.
>>>
>>>
>>> Garth
>>>
>>
>> As long as this patch applies cleanly to wxWidgets 3.0.2 and 3.0.1 then
>> I see no reason not to include it along with the rest of the patches.
>> Please generate the patch, confirm that it applies cleanly to wxWidgets
>> 3.0.2 and submit it.
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>