← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix place track menu hotkey text

 

Le 07/11/2014 23:24, Nick Østergaard a écrit :
> Hello
> 
> The attached patch makes the shortcut text label for the "Place ->
> Track" menu option show the hotkey as it is done in every other menu.
> Before it showed for example "Place (X)" instead of
> "Place<whitespace>X", where the hotkey is right aligned in the second
> case.

They are not equivalent.
- hotkey X  switches the current tool to "place track mode" and starts
a track from the cursor position (therefore the cursor is expected to be
on the right location)
- click on menu switch the current tool to "place track mode", but does
not start a track

This is the reason one cannot use "Place<tab>X" instead of "Place (X)"
(there are other places in menus where the case happens: in zoom menu
for instance)

(I never found a reliable and easy way to know if a menu event was
created by clicking on a menu, or from its hotkey)

> 
> I also took the liberty to fix some indentation while I was there
> anyway. So therefore this patch, fixes the place track menu hotkey
> text.
> 
> Regards
> Nick Østergaard

-- 
Jean-Pierre CHARRAS


Follow ups

References