kicad-developers team mailing list archive

[Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>]

On Thu, Nov 13, 2014 at 4:08 AM, jp charras <jp.charras@xxxxxxxxxx> wrote:

> Le 12/11/2014 03:46, Cirilo Bernardo a écrit :
> > I have updated the patch for the reverse-engineering tool. The previous
> > patch used
> > additional layers named Underlay1 and Underlay2. This patch makes use of
> the
> > Eco1 and Eco2 layers. As a consequence, only code for the
> bitmap2component
> > tool is touched; the common, include, and pcbnew directories are not
> > touched by
> > this current patch.
> >
> > The patch is available at:
> >
> > https://github.com/cbernardo/kicad-patches
> >
> > The patch was tested against revision 5259.
> > Thanks to everyone who has tried and commented on the previous patch.
> >
> > - Cirilo
>
> I committed your patch in rev 5262.
> I applied your patch with some minor changes.
> Mainly allows also the solder mask layer and keep ref and value fields
> on the silk layer.
> these fields could be also allowed on the fab layer (later).
> Thanks.
>
> Just about your patch on https://github.com/cbernardo/kicad-patches, a
> only one single diff file (without any .cpp or other file to copy) is by
> far better.
> There many reasons:
> A diff patch file shows more easily your changes and is very fast to apply.
> Copying files create issues: bad end of line, bad date.
> I had to update these copied files.
> And could create more issues if the initial .cpp file was modified.
>
> A single patch file avoids these issues.
> Still, thanks.
>
>
> --
> Jean-Pierre CHARRAS
>

Thanks Jean-Pierre,

 In the future I'll use the normal single diffs.

- Cirilo