← Back to team overview

kicad-developers team mailing list archive

Re: wxwidgets-3.0.2_macosx_yosemite.patch is a metapatch

 

Adam,

I committed the updated patch in the product branch r5265.

Thanks,

Wayne

On 11/11/2014 8:54 PM, Adam Wolf wrote:
> Sorry folks! This is my fault.
> 
> I attached a patch against the latest bzr at the time, and I think Wayne
> thought it was the actual patch that belonged in the patches directory.
> 
> I have attached a patch, that when applied to the latest version of
> kicad, will fix the patch.
> 
> (If you want to see what it looks like when a snake eats its own tail,
> read the attached patch.)
> 
> Adam Wolf
> Cofounder and Engineer
> W&L
> 
> On Sat, Nov 8, 2014 at 7:30 AM, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx
> <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>> wrote:
> 
>     Hi Garth,
> 
>     I guess that's one way to make sure it won't affect Windows or Linux! :)
> 
>     Unfortunately, I can't take a look at this until Monday.
> 
>     Adam Wolf
>     Cofounder and Engineer
>     W&L
> 
>     On Sat, Nov 8, 2014 at 2:27 AM, Garth Corral <gcorral@xxxxxxxxx
>     <mailto:gcorral@xxxxxxxxx>> wrote:
> 
> 
>         Hi, it’s late so maybe I’m just confused, but the newly added
>         yosemite patch appears to add a patch that would patch the
>         intended file, rather than doing the patching itself.
> 
>         === added file
>         'patches/wxwidgets-3.0.2_macosx_yosemite_webview_webkit.mm.patch'
>         ---
>         patches/wxwidgets-3.0.2_macosx_yosemite_webview_webkit.mm.patch1970-01-01
>         00:00:00 +0000
>         +++
>         patches/wxwidgets-3.0.2_macosx_yosemite_webview_webkit.mm.patch2014-10-29
>         18:17:55 +0000
>         @@ -0,0 +1,11 @@
>         +--- src/osx/webview_webkit.mm.orig2014-09-16 07:27:52.000000000
>         -0600
>         ++++ src/osx/webview_webkit.mm
>         <http://webview_webkit.mm>2014-09-16 07:28:12.000000000 -0600
>         +@@ -28,7 +28,7 @@
>         + #include "wx/hashmap.h"
>         + #include "wx/filesys.h"
>         +
>         +-#include <WebKit/WebKit.h>
>         ++#include <WebKit/WebKitLegacy.h>
>         + #include <WebKit/HIWebView.h>
>         + #include <WebKit/CarbonUtils.h>
>         +
> 
>         _______________________________________________
>         Mailing list: https://launchpad.net/~kicad-developers
>         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         Unsubscribe : https://launchpad.net/~kicad-developers
>         More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 




Follow ups

References