kicad-developers team mailing list archive

[Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx>]

Hi again,

I forgot…

If you want to put it into the bundle (what I really would vote for, see end of the mail), then you can use
  GetOSXKicadDataDir()
defined in common/common.cpp to get the path to the SharedSupport folder inside of the main bundle.

Also, I would propose to correctly wrap all OSses in correct #ifdefs and only define one path (at least for OS X).
That’s how I did with the previous patches changing paths.

It basically doesn’t hurt to have more than one path defined, but IMHO this only creates confusion, because in the end you have many possibilities but you don’t know where it is intended to be. And, this is something a normal user shouldn’t see/change at all, so there is no need to have choices.

Regarding the links you mentioned in your previous mail:
The links are just helpers for those who directly want to run pcbnew et. al.
If you throw them all away you are still able to do everything by means of the kicad launcher.
The same is true if you move kicad.app to another place… old links won’t work any longer, you might have to create new ones, but everything will always work via the kicad launcher.
This won’t be true if you don’t put the help files *inside* the kicad.app bundle… if you move kicad.app around, help files won’t work any longer.
As I understood OSX the concept of an application is the bundle, not a folder, dmg or something else.
Everything needed for the app to run self-contained has to be inside the bundle...


Regards,
Bernhard

On 18.11.2014, at 07:35, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx> wrote:

> Hi,
> 
> since help files is something directly used/delivered with KiCad (nothing that a user can/will change), shouldn’t this directly go into the bundle.
> E.g., kicad.app/Contents/SharedSupport/help?
> 
> If you put on the same level as kicad.app, you can’t move kicad.app around as you like I guess (without moving also help files around).
> 
> 
> Regards,
> Bernhard
> 
> On 18.11.2014, at 06:54, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
>> Hi folks,
>> 
>> I have set up a patch for adding an additional search path for help files for OS X.
>> 
>> It searches inside a help/ directory at the same level as the kicad.app/ bundle, along side eeschema.app and all the other .apps.
>> 
>> I have tested this on my OS X 10.10 system.
>> 
>> Please let me know if you have any feedback on the patch.  I am fine wrapping it all in an OSX ifdef, but it looks like the Windows and Linux ones are not (and were, historically, but that part is commented out?)
>> 
>> I tried to match the existing code in the file as much as I could.
>> 
>> Thanks!
>> 
>> Adam Wolf
>> Cofounder and Engineer,
>> W&L
>> <mac-helpfiles.patch>_______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp