kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

Hi John,

This still doesn't work correctly unless the footprint is already the
current item selected.  It behaves the same in both the GAL and legacy
rendering modes.  You should not have to select an item first to make a
hot keys work.  Try adding a test for an item under the cursor and then
launch the footprint editor rather than just exiting when nothing is
selected.

Wayne

On 12/2/2014 4:16 PM, John Beard wrote:
> On Mon, 2014-12-01 at 13:22 -0500, Wayne Stambaugh wrote:
>> Hi John,
>>
>> Sorry it took so long to try out this patch but I've been busy.  I found
>> a segfault on the first attempt to use Ctrl-E when no previous item has
>> been selected.  
> 
> D'oh, what a clanger!
> 
>> Once you fix this issue, I'll commit the patch.
> 
> I have fixed the issue, and I have also added the same functionality to
> the GAL PCB editor. I have also taken the opportunity to break some
> duplicated code out into a re-usable function:
> 
>     void PCB_EDIT_FRAME::ShowModuleEditorForModule( MODULE* aModule )
> 
> I think I'm starting to get the hang of the GAL, now! Hopefully I got it
> more or less right!
> 
> Cheers,
> 
> John
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>