kicad-developers team mailing list archive

[Johannes Maibaum <jmaibaum@xxxxxxxxx>]

I just realized that my patch won't really change the execute flag for osx_build_wx.sh. I read from the bzr FAQs that normally the execute flag is being tracked
(http://wiki.bazaar.canonical.com/FAQ #4.4). However, it seems that patches cannot convey a
change to the flag of a file in the tree. The last line of my patch clearly mentions the
change.

Some quick checks show that neither patching with 'patch', nor with 'bzr patch' (from
bzrtools) will change the flag. For classic 'patch' this seems OK, since they explicitly state in their man file that file permission changes won't work. But shouldn't it work
for bzr? I created the patch file with 'bzr diff', as suggested in Documentation/HOW_TO_CONTRIBUTE.txt.

I also tried to bzr rm the script and then re-add it with the correct permissions. But
still, the execute flag won't survive within a patch.


Johannes

> Am 08.12.2014 um 17:16 schrieb Andy Peters <devel@xxxxxxxxx>:
> 
> I also had to do the chmod +x on the osx_build_wx.sh script.