kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Bernhard,

I'll hold off committing this until I see some consensus among the OSX
developers and users.  I want to avoid committing a patch that doesn't
fix the issue.  Please keep me posted.

Thanks,

Wayne

On 12/22/2014 7:52 AM, Bernhard Stegmaier wrote:
> Hi,
> 
> first… yes, the patch does bring back the file filter drop down (it
> seems to be disabled also on 10.9).
> 
> Different from the patch I have added the code to 
>   bool PGM_BASE::initPgm()
> because this seems to be one of the more global spots to initialize things.
> I am not sure about that… in kiface_i.cpp 
>   bool KIFACE_I::start_common( int aCtlBits )
> would also maybe appropriate?
> 
> But… even if it brings back the filter drop down, it doesn’t seem to
> work with wxWidgets 3.0.2.
> The
> <<<
>     wxFileDialog dlg( aParent, _( "Open Board File" ), path, name,
> fileFilters,
>                       wxFD_OPEN | wxFD_FILE_MUST_EXIST );
> 
>     if( dlg.ShowModal() != wxID_CANCEL )
>     {
>         int chosenFilter = dlg.GetFilterIndex();
>>>>
> dlg.GetFilterIndex() always return 0 regardless from what I choose.
> Moreover, changing the filter does not affect the file list at all (from
> the wxWidgets code it should…).
> I guess files not matching the current filter should get greyed out, but
> always all supported files are enabled.
> 
> So, this doesn’t really seem to fix the original problem - at least on
> both my 10.9 and 10.10 setup.
> Can somebody else confirm this?
> 
> 
> Regards,
> Bernhard
> 
>> On 20.12.2014, at 15:33, Wayne Stambaugh <stambaughw@xxxxxxxxx
>> <mailto:stambaughw@xxxxxxxxx>> wrote:
>>
>> On 12/9/2014 1:57 PM, Paulo Henrique Silva wrote:
>>>
>>> Some KiCAD open dialogs require the usage of the file filter combobox to
>>> decide which loader to use (e.g., on pcbnew, to import an Eagle or gEDA
>>> board).
>>>
>>> On recent OS X the file filter combo is gone and we therefore cannot
>>> choose to import anything different than the default filter option.
>>> (tested on Yosemite)
>>>
>>> wxWidgets have a system option to force OS X to show the filter combo, I
>>> tested here but I am not sure where to add it. It needs to be in a file
>>> that is executed for all apps independent of being in standalone mode.
>>>
>>> To test it on pcbnew use the attached patch.
>>>
>>> Cheers,
>>>
>>> -- Paulo Henrique
>>> -- Curta Circuitos
>>>
>>
>> Would one of the OSX devs please test this patch for me and see if it
>> makes sense.  If so, let me know and I will commit it.
>>
>> Thanks,
>>
>> Wayne
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>