← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] GAL hotkey event handling causing beeps on OSX

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

I cannot recall why it has been done that way (maybe wx2.8 issue?).
Currently the Tool Framework handles the hot keys in its own way, so
there is a chance that passing the events would not be necessary.

Unfortunately, there is another issue - with the patch applied, one
cannot draw a selection box in GAL. Does not it happen with OS X?

Regards,
Orson

On 01/05/2015 03:15 PM, Wayne Stambaugh wrote:
> This patch doesn't look correct to me.  I don't see how it doesn't
> break anything else.  If the events are not passed up the event
> handler chain as noted in the comment, other event handlers cannot
> respond to them. Tom or Orson, do you have any input on this?
> 
> On 1/5/2015 2:30 AM, Paulo Henrique Silva wrote:
>> Dears,
>> 
>> When using OpenGL canvas on OS X (not tested on other platforms)
>> every time a hotkey is pressed I get a beep after the desired
>> action is completed (For instance, using H to toggle high
>> contrast mode).
>> 
>> Attached patch fix it. Event handling borrowed from regular
>> canvas which only pass the event back to the system (.Skip())
>> when an action was not handled.
>> 
>> Not sure about possible side effects on it tough.
>> 
>> Cheers,
>> 
>> -- Paulo Henrique -- Curta Circuitos -- Brazil
>> 
>> 
>> _______________________________________________ Mailing list:
>> https://launchpad.net/~kicad-developers Post to     :
>> kicad-developers@xxxxxxxxxxxxxxxxxxx Unsubscribe :
>> https://launchpad.net/~kicad-developers More help   :
>> https://help.launchpad.net/ListHelp
>> 
> 
> 
> _______________________________________________ Mailing list:
> https://launchpad.net/~kicad-developers Post to     :
> kicad-developers@xxxxxxxxxxxxxxxxxxx Unsubscribe :
> https://launchpad.net/~kicad-developers More help   :
> https://help.launchpad.net/ListHelp
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJUqqOgAAoJEBRwGu1hpbJ17vkIAKFrK+W58HRdbfv5WO4q3wNw
9MhoWMJXHfhD74s9mbXlKnaEV+KDew9E9oIxfvi4od/voCiIe2V6uqpQehtIeNlQ
v0rpPyEdznM4HFHQcjRRW1Oab2Xay+HE0CO+OwgdWg0wjktBH+sSDLOs5ns4sGFW
SSblI9E3sp2nHxyNR6ueb3aU9U9IvmUi9OWAplr/QIdmEvEv8FRcIy5cix5KgEsS
4BVdGe4N9w5uPMWyPXQSgPAKEmyH5zdNQF/ggkpnVAqedbsZnDnnwOVt3kShCeRq
fN5axpj04jKE+1fYjGHIRvntQPSPxNwt9SJfUSbd4IQ5xYVOsWa1ekhcbOLOteI=
=vjod
-----END PGP SIGNATURE-----


Follow ups

References