← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Hotkey for editing module with module editor (Ctrl-E)

 

On 02.12.2014 22:16, John Beard wrote:
> On Mon, 2014-12-01 at 13:22 -0500, Wayne Stambaugh wrote:
>> Hi John,
>>
>> Sorry it took so long to try out this patch but I've been busy.  I found
>> a segfault on the first attempt to use Ctrl-E when no previous item has
>> been selected.  
> 
> D'oh, what a clanger!
> 
>> Once you fix this issue, I'll commit the patch.
> 
> I have fixed the issue, and I have also added the same functionality to
> the GAL PCB editor. I have also taken the opportunity to break some
> duplicated code out into a re-usable function:
> 
>     void PCB_EDIT_FRAME::ShowModuleEditorForModule( MODULE* aModule )
John,

Please don't work on this in GAL mode. I already implemented that
feature (alongside the P&S changes).

Cheers,
Tom


Follow ups

References