kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 01/02/2015 15:08, Miguel Ángel Ajo a écrit :
> 
> 
> It’s actually not very important (I guess), but I found that this commit that broke
> the pcb bounding box calculation (at least the calculated size doesn’t match the expected
> for some reason).
> 

I do not think the commit has something to do with that.
In fact, test_002_board_class.py does not calculate the track bounding
box like Pcbnew.
For a track the bounding box includes the track + its clearance area,
which is needed by the fact the clearance area is a part of the track
(in drawing functions, or copper zone calculations.)
But test_002_board_class.py does not take in account this clearance.

> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/qa/testcases/test_002_board_class.py#L36
> 
> http://ci.kicad-pcb.org/job/kicad-qa/558/changes
> 
> http://ci.kicad-pcb.org/job/kicad-qa/558/console
> 
> 05:13:18 ====================================================================== 05:13:18 FAIL: test_pcb_bounding_box (test_002_board_class.TestBoardClass) 05:13:18 ---------------------------------------------------------------------- 05:13:18 Traceback (most recent call last): 05:13:18 File "/var/lib/jenkins/workspace/kicad-qa/qa/testcases/test_002_board_class.py", line 54, in test_pcb_bounding_box 05:13:18 self.assertAlmostEqual(width, (30-10) + 0.5, 2) 05:13:18 AssertionError: 21.008002999999999 != 20.5 within 2 places 05:13:18 05:13:18 ----------------------------------------------------------------------
> 
> I will try to look at it, but first I need to fix QA to make sure it will catch actual testing errors like this, because if you see
> at the end of the console, even if the test started failing long ago we had a big “SUCCESS”.  
> 
> Miguel Ángel Ajo
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS