kicad-developers team mailing list archive

[Miguel Ángel Ajo <majopela@xxxxxxxxxx>]

Hi, thanks nick!, I was going to look into it, but we have only HTTP  
for ci.kicad-pcb.org, and not HTTPS, so I don’t want to login over
the open FOSDEM wifi… (for just in case somebody is logging)


Miguel Ángel Ajo


On Sunday, 1 de February de 2015 at 15:51, Nick Østergaard wrote:

> Regarding fixing the qa, i have a patch but I am not home now.
> Den 01/02/2015 15.09 skrev "Miguel Ángel Ajo" <majopela@xxxxxxxxxx (mailto:majopela@xxxxxxxxxx)>:
> >  
> >  
> > It’s actually not very important (I guess), but I found that this commit that broke
> > the pcb bounding box calculation (at least the calculated size doesn’t match the expected
> > for some reason).
> >  
> > http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/qa/testcases/test_002_board_class.py#L36
> >  
> > http://ci.kicad-pcb.org/job/kicad-qa/558/changes
> >  
> > http://ci.kicad-pcb.org/job/kicad-qa/558/console
> >  
> > 05:13:18 ====================================================================== 05:13:18 FAIL: test_pcb_bounding_box (test_002_board_class.TestBoardClass) 05:13:18 ---------------------------------------------------------------------- 05:13:18 Traceback (most recent call last): 05:13:18 File "/var/lib/jenkins/workspace/kicad-qa/qa/testcases/test_002_board_class.py", line 54, in test_pcb_bounding_box 05:13:18 self.assertAlmostEqual(width, (30-10) + 0.5, 2) 05:13:18 AssertionError: 21.008002999999999 != 20.5 within 2 places 05:13:18 05:13:18 ----------------------------------------------------------------------
> >  
> > I will try to look at it, but first I need to fix QA to make sure it will catch actual testing errors like this, because if you see
> > at the end of the console, even if the test started failing long ago we had a big “SUCCESS”.  
> >  
> > Miguel Ángel Ajo
> >  
> >  
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx (mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx)
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >  
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx (mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx)
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>  
>