← Back to team overview

kicad-developers team mailing list archive

EDA_DRAW_MODE_T changes

 

Found this during my merge today... (lot of time since the last one)
The text drawing routine didn't compile :P

For some reason from EDA_DRAW_MODE_T the LINE mode was removed. In fact
it degenerated to a boolean, in many spots.

Why was that done? I agree that having tracks in LINE mode is completely
useless but working with text and module lines in LINE mode reduce
considerably visual clutter (i.e. I want to see the tracks, not how fat
is my silk screen). OTOH having text in sketch mode is... questionable,
but maybe someone has some use for it :D

I consider it a significant loss of feature. Unless, as I hope, true
means 'FILLED' and false means 'LINE' for text and 'SKETCH' for tracks;
but what about module lines? these are usefully shown in all the three
modes...

I hope there is a *very* good reason for that, I rely quite a lot on
that functionality.

Also, were all the plot engines checked for correct functionality?
Expecially DXF which is most useful in line mode (IIRC sketch and filled
are the same in DXF, but it was a long time ago...)

-- 
Lorenzo Marcantonio
Logos Srl


Follow ups