← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] IDF code: fixing problems reported by coverity

 

2015-02-17 7:49 GMT+01:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
> 2015-02-17 4:41 GMT+01:00 Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>:
>> My bad; I didn't quite get the logical flow and missed quite a few more
>> deletes.
>>
>> I've attached a patch that should fix that as well as 2 issues in
>> 'export_vrml.cpp'
>>
>> Since the issue in idf_parser.cpp can only be tripped if the input file is
>> defective
>> and the issues in export_vrml.cpp are minor (for various reasons they do not
>> constitute bugs as the code stands) I'd recommend applying the patch now
>> and I'll check the status again whenever the next coverity scan is done.
>>
>> I haven't been able to take ownership of any of the issues; is there an
>> admin
>> privilege somewhere or am I missing something?
>
> I think you should be able to do that under the Triage manu on the
> right, there is a label with "Owner:" where you can enter names of the
> people assigned the project.

Or well, it seems to only show the e-mail addresses.

>> On Tue, Feb 17, 2015 at 1:47 PM, Mark Roszko <mark.roszko@xxxxxxxxx> wrote:
>>>
>>> Coverity reports #102373 was not fixed.
>>>
>>> If while( aLibFile.good() ) is not true, it'll end up exiting the
>>> function with pout not freed.
>>>
>>> Also this is a good example of why you should mark issues you fix or
>>> ignore in Coverity. It's easier to check later if it got fixed.
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>


References