kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Cirilo,

I committed your patch in the product branch version r5436.

Thanks,

Wayne

On 2/16/2015 10:41 PM, Cirilo Bernardo wrote:
> My bad; I didn't quite get the logical flow and missed quite a few more
> deletes.
> 
> I've attached a patch that should fix that as well as 2 issues in
> 'export_vrml.cpp'
> 
> Since the issue in idf_parser.cpp can only be tripped if the input file
> is defective
> and the issues in export_vrml.cpp are minor (for various reasons they do not
> constitute bugs as the code stands) I'd recommend applying the patch now
> and I'll check the status again whenever the next coverity scan is done.
> 
> I haven't been able to take ownership of any of the issues; is there an
> admin
> privilege somewhere or am I missing something?
> 
> - Cirilo
> 
> 
> On Tue, Feb 17, 2015 at 1:47 PM, Mark Roszko <mark.roszko@xxxxxxxxx
> <mailto:mark.roszko@xxxxxxxxx>> wrote:
> 
>     Coverity reports #102373 was not fixed.
> 
>     If while( aLibFile.good() ) is not true, it'll end up exiting the
>     function with pout not freed.
> 
>     Also this is a good example of why you should mark issues you fix or
>     ignore in Coverity. It's easier to check later if it got fixed.
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
> 
>