kicad-developers team mailing list archive

[Mark Roszko <mark.roszko@xxxxxxxxx>]

I really don't agree with this patch with marking all the subclasses
as virtual just because if the base class parameters ever change for a
method the subclasses end up making entirely new functions. And you
won't get any errors because it'll just call the base method no
problem.

If we did C++11 (which KiCad doesn't because Boost shoots itself in
the head). Then virtual AND the override keyword make it entirely
great and safe.