← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Set dash lines parameters in one place for plot

 

Le 09/03/2015 16:29, Eldar Khayrullin a écrit :
> It is possible? May be you mean that need check this condition?
> 
> 09.03.2015 18:19, jp charras пишет:
>> Le 09/03/2015 15:36, Eldar Khayrullin a écrit :
>>> I deleted Magic numbers that set parameters of dash lines. Use constants
>>> in mils. Then apply radius correction and scale to plot units when start
>>> to plotting.
>>> Make for PDF, PS, SVG plotters.
>>> And some minor fixes.
>> Thanks.
>> But what happens when DASH_MARK_LENGTH <= currentPenWidth ?
>>
>>

Because the currentPenWidth can be > DASH_MARK_LENGTH, checking the dash
mark length always > 0 to avoid issues is certainly good.
(although this is an unusual pen width value, but who know!)

(and use the virtual GetCurrentLineWidth() instead of currentPenWidth is
better)

-- 
Jean-Pierre CHARRAS


Follow ups

References