← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] fix 2x memory leak and misc field warnings in PNS stuff

 

I believe uncommit will remove all of the changes since r5495 as well as
r5495.  I don't think that is what you want to do.  Uncommit would have
been fine if there were no other commits after r5495 but it's too late
for that now.  I doubt it's worth the effort at this point.

On 3/10/2015 3:12 PM, Bernhard Stegmaier wrote:
> Maybe this helps:
> http://stackoverflow.com/questions/9730755/is-there-a-bazaar-equivalent-to-git-commit-amend
> 
> 
> Regards,
> Bernhard
> 
>> On 10 Mar 2015, at 17:57, Maciej Sumiński <maciej.suminski@xxxxxxx
>> <mailto:maciej.suminski@xxxxxxx>> wrote:
>>
>> Mark,
>>
>> I committed your patch in 5495, but by oversight I have not used your
>> name as the author. I sincerely apologize for the error, I promise to be
>> more careful next time.
>>
>> If anyone knows a way to fix it without forceful overwriting the
>> repository, please let me know. I really hope you are not offended by my
>> mistake.
>>
>> Kind regards,
>> Orson
>>
>> On 03/10/2015 05:08 AM, Mark Roszko wrote:
>>> Fixes 1 leak in pns_line_placer and 1 leak in pns_node.
>>> Assorted field intialization.
>>>
>>> Based on coverity.
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References