kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

2015-03-10 21:30 GMT+01:00 jp charras <jp.charras@xxxxxxxxxx>:
> Le 10/03/2015 21:05, Nick Østergaard a écrit :
>> 2015-03-10 21:02 GMT+01:00 jp charras <jp.charras@xxxxxxxxxx>:
>>> Le 09/03/2015 17:24, Eldar Khayrullin a écrit :
>>>> Add check to negative values of mark length. Use GetCurrentLineWidth()
>>>> instead of currentPenWidth.
>>>>
>>>> 09.03.2015 19:06, jp charras пишет:
>>>>> Le 09/03/2015 16:29, Eldar Khayrullin a écrit :
>>>>>> It is possible? May be you mean that need check this condition?
>>>>>>
>>>>>> 09.03.2015 18:19, jp charras пишет:
>>>>>>> Le 09/03/2015 15:36, Eldar Khayrullin a écrit :
>>>>>>>> I deleted Magic numbers that set parameters of dash lines. Use
>>>>>>>> constants
>>>>>>>> in mils. Then apply radius correction and scale to plot units when
>>>>>>>> start
>>>>>>>> to plotting.
>>>>>>>> Make for PDF, PS, SVG plotters.
>>>>>>>> And some minor fixes.
>>>>>>> Thanks.
>>>>>>> But what happens when DASH_MARK_LENGTH <= currentPenWidth ?
>>>>>>>
>>>>>>>
>>>>> Because the currentPenWidth can be > DASH_MARK_LENGTH, checking the dash
>>>>> mark length always > 0 to avoid issues is certainly good.
>>>>> (although this is an unusual pen width value, but who know!)
>>>>>
>>>>> (and use the virtual GetCurrentLineWidth() instead of currentPenWidth is
>>>>> better)
>>>
>>> I just committed your patch.
>>> I made very minor changes (default values in mm and set to give the same
>>> size as dashed lines drawn by wxDC, using short dash style.)
>>>
>>> Thanks.
>>
>> Is there any reason not to support solid lines, when there exists code
>> functions to create them?
>
> Supporting different styles for graphic lines is easy, but need changes
> in schematic file format to store the style..
> We want to avoid changes in schematic file format, at least for now.

Ohh, well, I follow that, but I this patch sort of break the
appearance of a lot of peoples schematics without a fix. I was looking
into the issue myself, but it also seemed like a something had to be
done to store the information in file.

>  Also the crosshair in the module editor has
>> become dashed...
>
> Do you mean axis ?
> The crosshair is not dashed for me.

Yeah, I probably mean that axis. The blue one in the middle when starting.