← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] eeschema restructure of netlist export code

 

Le 21/03/2015 06:55, Mark Roszko a écrit :
> I was investigating improvements and functionality related to
> netlisting and this is something that bothered me.
> 
> Right now eeschema has all the netlist exporting code shoved into netform.cpp
> Besides the file being a funny name for what it does, it's a rather
> annoying a mix of code with different groups of functionality (i.e.
> all the netlists).
> 
> So this patch implements netlist exporting code as a class structure.
> 
> structure:
> netlist_exporter
> |---netlist_exporter_pspice
> |---netlist_exporter_generic
>     |--netlist_exporter_kicad
> |---netlist_exporter_orcadpcb2
> |---netlist_exporter_cadstar
> 
> This cleans things up to make it easier to maintain the netlisters in
> my opinion (or at least I can tell what function goes with what
> clearly )
> 
> Each class implements a "Write" function that gets called to actually
> output the data to file.
> 
> netform.cpp now just has the sch_edit frame function that loads the
> right class and calls a standard Write function. Each class handles
> file opening however it needs.
> 
> Other change:
> -Eliminated legacy pcbnew format option as the dialog option no longer
> existed anyway
> 
> No changes to the actual netlisting has been made. This is purely code
> restructuring.

I committed you patch. Thanks.

The netlist export code is now more easier to maintain.


-- 
Jean-Pierre CHARRAS


References