← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Assertion failure and can't close Hotkeys List

 

On Sat, Mar 21, 2015 at 02:38:36PM +0100, jp charras wrote:
> Le 21/03/2015 14:05, Marco Ciampa a écrit :
> > On Fri, Mar 20, 2015 at 08:12:36PM +0100, jp charras wrote:
> >> Le 20/03/2015 19:15, Chris Pavlina a écrit :
> >>> When the Hotkeys List was changed to non-modal, its OnCloseButtonClick()
> >>> was not changed to reflect the fact that modal and modeless dialogs have
> >>> to be closed differently in wx. Here's a patch to fix that, which should
> >>> work for all HTML_MESSAGE_BOXes whether or not they're modal.
> >>>
> >>> Chris
> >>
> >> Damn!
> >> you are right.
> >>
> >> I committed your patch. thanks.
> > 
> > And, BTW, why the hotkey list is not i18n? Using a HELP Window that do
> > not help you in your tongue, meanwhile all the program dialogs are
> > translated, is bizarre at least...
> > 
> 
> Well:
> - Most of hotkeys are the first letter of the command name (in English)

That is _not_ a problem, especially when translating a tutorial, having
the same keys.

> - These strings are also used as keywords in hotkey config file.
> Keep them in English is not so bad.

No, believe me. Either use the program in English or traslate _all_.
In this case IMHO a compromise is not accettable

> (this is also the case for .kicad_pcb files which are using English
> layers names for non copper layer.)

And I agree here. A document format/content is _not_ a help window.
I espect it to be read by different kind of people, not beginners anyway...

--


Marco Ciampa

I know a joke about UDP, but you might not get it.

+------------------------+
| GNU/Linux User  #78271 |
| FSFE fellow       #364 |
+------------------------+



Follow ups

References