kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 22/03/2015 02:52, Simon Richter a écrit :
> 
> This adds a new dialog giving an overview over the pins in the current
> component. Currently only pin number, name and type are shown. More
> functions, and editing support are planned.
> ---

Hi, Simon,

I tested your patches, and they add a *very good and very useful feature*.
I am willing to commit them, but I'll will *very* happy if you can fix
some (minor) issues:

- All dialogs in Kicad have to be internationalized and have a
RESIZE_BORDER style enabled (an option in wxFormBuilder)

- Have a look at our coding style policy: class names (and enums) are in
uppercase letters.
And about capitalization of class variable members, see:
https://lists.launchpad.net/kicad-developers/msg17487.html

Thanks for you involvement in Kicad.

-- 
Jean-Pierre CHARRAS