← Back to team overview

kicad-developers team mailing list archive

Re: Question on kicad-install.sh

 

Thank you.
From the original list:
1. install_prerequisites()This function is using a single command "apt-get install" for ALL of the software packages. It would work smoothly if ALL of the packages were available. Unfurtunately, in the Ubuntu 14.04 case, python-wxgtk3.0 is not yet available and the command will fail for ALL of the packages. Thus libwxgtk3.0-dev will not be installed at all (which will cause another error that needs an improved error handling. See #2). Suggestion: Change to use a local loop to install each of the packages so that command "apt-get install" fails only for a single package, thus avoiding failing for ALL. 2. CMake check listWhen libwxgtk3.0-dev is not installed, due to the faillure in #1 aboe, the CMake check part stops short during compiling, but kicad-install.sh does not detect this failed compiling and just continue to install or copy parts files and doc files into the destnated directory. At the end, it seems all install succeeded. But there is NO "kicad" binary installed at all, much less of the rest of the binaries. This situation has caused confussions to me a few times already.

It still seems that the loop is a bit silly, though. You have to sit there authorizing each and every install. Since python-wxgtk3.0 is apparently optional, how about just installing *that* one individually, and then installing the rest with a single command?

You could even test whether it's available and only attempt to install it if it is, or perhaps print an explanation of the consequences of not having it.

On Wed, Apr 01, 2015 at 03:34:56PM +0200, Nick Østergaard wrote:
https://lists.launchpad.net/kicad-developers/msg15134.html

2015-04-01 9:53 GMT+02:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
Search the mailing list archive. Try to also use the keyword fedora when
searching. I am currently not on a proper machine.

Den 01/04/2015 01.48 skrev "Chris Pavlina" <pavlina.chris@xxxxxxxxx>:

Does anyone know why kicad-install.sh does this?

for p in ${prerequisite_list}
do
   sudo apt-get install $p || exit 1
done

Rather than something along the lines of this:

echo "${prerequisite_list}" | xargs -d"\n" sudo apt-get install


The long prompts for permission to install each package have, erm,
aggravated some users, and adding -y isn't quite the right choice IMHO as it
removes the user's ability to veto the package list.

Any chance of changing it?

Chris


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


Follow ups

References