kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #17906
[PATCH 11/27] PinShape: move enum to own header
---
eeschema/lib_pin.h | 21 +--------------
eeschema/pin_shape.h | 50 +++++++++++++++++++++++++++++++++++
eeschema/widgets/pin_shape_combobox.h | 2 +-
3 files changed, 52 insertions(+), 21 deletions(-)
create mode 100644 eeschema/pin_shape.h
diff --git a/eeschema/lib_pin.h b/eeschema/lib_pin.h
index 912b517..c2787ee 100644
--- a/eeschema/lib_pin.h
+++ b/eeschema/lib_pin.h
@@ -32,6 +32,7 @@
#include <lib_draw_item.h>
+#include "pin_shape.h"
#define TARGET_PIN_RADIUS 12 // Circle diameter drawn at the active end of pins
@@ -58,26 +59,6 @@ enum ElectricPinType {
#define PIN_INVISIBLE 1 /* Set makes pin invisible */
-enum PinShape
-{
- PINSHAPE_LINE,
- PINSHAPE_INVERTED,
- PINSHAPE_CLOCK,
- PINSHAPE_INVERTED_CLOCK,
- PINSHAPE_INPUT_LOW,
- PINSHAPE_CLOCK_LOW,
- PINSHAPE_OUTPUT_LOW,
- PINSHAPE_FALLING_EDGE_CLOCK,
- PINSHAPE_NONLOGIC
-};
-
-
-enum
-{
- PINSHAPE_COUNT = PINSHAPE_NONLOGIC + 1
-};
-
-
/**
* The component library pin object orientations.
*/
diff --git a/eeschema/pin_shape.h b/eeschema/pin_shape.h
new file mode 100644
index 0000000..1d96435
--- /dev/null
+++ b/eeschema/pin_shape.h
@@ -0,0 +1,50 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2004-2015 KiCad Developers, see change_log.txt for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
+ */
+
+/**
+ * @file pin_shape.h
+ * @brief Pin shape handling
+ */
+
+#ifndef _PIN_SHAPE_H_
+#define _PIN_SHAPE_H_
+
+enum PinShape
+{
+ PINSHAPE_LINE,
+ PINSHAPE_INVERTED,
+ PINSHAPE_CLOCK,
+ PINSHAPE_INVERTED_CLOCK,
+ PINSHAPE_INPUT_LOW,
+ PINSHAPE_CLOCK_LOW,
+ PINSHAPE_OUTPUT_LOW,
+ PINSHAPE_FALLING_EDGE_CLOCK,
+ PINSHAPE_NONLOGIC
+};
+
+enum
+{
+ PINSHAPE_COUNT = PINSHAPE_NONLOGIC + 1
+};
+
+#endif
diff --git a/eeschema/widgets/pin_shape_combobox.h b/eeschema/widgets/pin_shape_combobox.h
index 19c9714..b9ef4e0 100644
--- a/eeschema/widgets/pin_shape_combobox.h
+++ b/eeschema/widgets/pin_shape_combobox.h
@@ -28,7 +28,7 @@
#include <wx/bmpcbox.h>
-#include <lib_pin.h>
+#include <pin_shape.h>
class PinShapeComboBox : public wxBitmapComboBox
{
Follow ups
References
-
[PATCH 00/27] My current patch stack
From: Simon Richter, 2015-04-13
-
[PATCH 01/27] Move feature check before dependent tests
From: Simon Richter, 2015-04-13
-
[PATCH 02/27] Use Link Time Optimization with GCC in Release builds
From: Simon Richter, 2015-04-13
-
[PATCH 03/27] Make NETLIST_OBJECT::GetConnectionType() const
From: Simon Richter, 2015-04-13
-
[PATCH 04/27] Remove superfluous cast
From: Simon Richter, 2015-04-13
-
[PATCH 05/27] Separate ElectricPinType and TypeSheetLabel
From: Simon Richter, 2015-04-13
-
[PATCH 06/27] Regenerate "Edit Pin" dialog with newer wxFormBuilder
From: Simon Richter, 2015-04-13
-
[PATCH 07/27] Replace DrawPinShape enum with PinShape
From: Simon Richter, 2015-04-13
-
[PATCH 08/27] PinShapeComboBox: Introduce widget
From: Simon Richter, 2015-04-13
-
[PATCH 09/27] PinShapeComboBox: Fully initialize in c'tor
From: Simon Richter, 2015-04-13
-
[PATCH 10/27] PinShapeComboBox: typesafe Get/Set
From: Simon Richter, 2015-04-13