← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] S3D Mesh Smart Pointer

 

I just tested with VRML 1 and VRML 2 and stuff has appeared not to
break, so I just committed this change.

I opted for the boost::shared_ptr as we're not yet C++11 and there is
quite a bit of standard container work going on.

Best Regards,

Brian.


On 11 April 2015 at 00:04, Brian Sidebotham <brian.sidebotham@xxxxxxxxx> wrote:
> Hi Guys,
>
> Could someone who has access to both vrml1 and vrml2 models please
> test the attached patch which uses a smart pointer rather than
> S3D_MESH* to get rid of some coverity issues and feedback whether it
> makes your computer explode, or carry on working normally?
>
> Alternatively, could someone email a couple of vrml files that would
> exercise it and I'll put it through it's paces...
>
> Sorry, there's white space deletions going on in the patch so it's a bit noisy.
>
> Thanks,
>
> Brian.


Follow ups

References