← Back to team overview

kicad-developers team mailing list archive

[PATCH] lib-cache-rescue coding style fixes

 

Here's a patch that fixes a few minor coding style issues with lib-cache-rescue.

--
Chris

commit 18380f35788821b508c4a01a420f67d17eea4d37
Author: Chris Pavlina <cpavlin1@xxxxxxxxxxxxxx>
Date:   Sun May 3 12:26:55 2015 -0400

    Fix coding style
    
    Add space inside parentheses

diff --git a/eeschema/dialogs/dialog_rescue_each.cpp b/eeschema/dialogs/dialog_rescue_each.cpp
index 3a20775..54e1842 100644
--- a/eeschema/dialogs/dialog_rescue_each.cpp
+++ b/eeschema/dialogs/dialog_rescue_each.cpp
@@ -99,10 +99,10 @@ bool DIALOG_RESCUE_EACH::TransferDataToWindow()
     if( !wxDialog::TransferDataToWindow() )
         return false;
 
-    m_ListOfConflicts->AppendToggleColumn( _("Rescue symbol") );
-    m_ListOfConflicts->AppendTextColumn( _("Symbol name") );
-    m_ListOfInstances->AppendTextColumn( _("Reference") );
-    m_ListOfInstances->AppendTextColumn( _("Value") );
+    m_ListOfConflicts->AppendToggleColumn( _( "Rescue symbol" ) );
+    m_ListOfConflicts->AppendTextColumn( _( "Symbol name" ) );
+    m_ListOfInstances->AppendTextColumn( _( "Reference" ) );
+    m_ListOfInstances->AppendTextColumn( _( "Value" ) );
     PopulateConflictList();
     PopulateInstanceList();
 
@@ -152,7 +152,7 @@ void DIALOG_RESCUE_EACH::PopulateInstanceList()
 
         data.clear();
         data.push_back( each_component->GetRef( & m_Parent->GetCurrentSheet() ) );
-        data.push_back( valueField ? valueField->GetText() : wxT("") );
+        data.push_back( valueField ? valueField->GetText() : wxT( "" ) );
         m_ListOfInstances->AppendItem( data );
 
     }
diff --git a/eeschema/lib_cache_rescue.cpp b/eeschema/lib_cache_rescue.cpp
index e8f9680..e4a7bd6 100644
--- a/eeschema/lib_cache_rescue.cpp
+++ b/eeschema/lib_cache_rescue.cpp
@@ -247,7 +247,7 @@ static void find_rescues( std::vector<SCH_COMPONENT*>& aComponents, PART_LIBS* a
 static PART_LIB* create_rescue_library( wxFileName& aFileName )
 {
     wxFileName fn( g_RootSheet->GetScreen()->GetFileName() );
-    fn.SetName( fn.GetName() + wxT("-rescue") );
+    fn.SetName( fn.GetName() + wxT( "-rescue" ) );
     fn.SetExt( SchematicLibraryFileExtension );
     aFileName.SetPath( fn.GetPath() );
     aFileName.SetName( fn.GetName() );
@@ -321,7 +321,7 @@ bool SCH_EDIT_FRAME::RescueCacheConflicts( bool aRunningOnDemand )
     get_components( components );
     prj = &Prj();
     libs = prj->SchLibs();
-    part_name_suffix =  wxT("-RESCUE-") + prj->GetProjectName();
+    part_name_suffix =  wxT( "-RESCUE-" ) + prj->GetProjectName();
 
     // Start!
     find_rescues( components, libs, candidates );

Follow ups