← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

 

Chris,

I just tested this and I like the changes.  I believe I found a bug.  I
just rescued an old project and noticed all of the zener diodes were
oriented 180 degrees from the unrescued version.  When you get a chance,
would you please verify the component orientation against the rescued
library is correct.  I'll commit this patch.  If you find a bug, please
apply the patch against this patch.

Thanks,

Wayne

On 5/4/2015 1:30 PM, Chris Pavlina wrote:
> I've got two changes here - they're a bit inadvertently intertwined, so
> I left them as one patch, otherwise one would depend on the other
> anyway. Let me know if you want me to discard half.
> 
> 1. Remove the summary dialog from lib-cache-rescue. I originally created
> it so the user would know what the new names of the components were; I
> compensated by changing the main dialog to display the suffix that will
> be added to the parts.
> 
> 2. Minor bugfix: If no parts are rescued, an empty rescue library
> shouldn't be written.
> 
> -- 
> Chris
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References