kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #18279
Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
2015-05-13 21:22 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
> I'm not sure why swapped pins in the system libraries would be an issue
> since the cached components should product the correct schematic.
> Assuming the rescue library is properly fetching the components from the
> cache library, I can't see how any changes in the system libraries would
> cause this. Unfortunately, did not make a back up of the cache library
> of the schematic I rescued so there is no way to get back that
> information. I'll see if I have another project that causes the issue.
Don't be offended, but that is why I always reccomend people to keep
their project versioned in their favorite VCS.
> On 5/13/2015 11:52 AM, Chris Pavlina wrote:
>> I don't use the KiCad libraries usually, so I'm unaware - were the pin
>> numbers swapped? If that's the case, I'm not sure of a way to handle
>> that gracefully, as from the software's perspective, pin 1 is pin 1 is
>> pin 1 - the fact that the cathode band is drawn elsewhere obviously
>> doesn't factor into that, it's just a graphical change.
>>
>> Any ideas on how I could handle that?
>>
>> --
>> Chris
>>
>>
>> On Wed, May 13, 2015 at 11:45:38AM -0400, Wayne Stambaugh wrote:
>>> This is altogether possible as I have recently installed the latest
>>> library changes.
>>>
>>> On 5/13/2015 11:37 AM, Maciej Sumiński wrote:
>>>> Is it possible the problem is related to the recent diode pin swapping
>>>> in KiCad library?
>>>>
>>>> Regards,
>>>> Orson
>>>>
>>>> On 05/13/2015 05:35 PM, Chris Pavlina wrote:
>>>>> Hi Wayne,
>>>>>
>>>>> That's interesting. I can't really imagine what would cause that, and I
>>>>> haven't seen anything like that - I've tested it on many projects that
>>>>> should have stirred that bug up if it existed. Any chance you can share
>>>>> with me the problem project?
>>>>>
>>>>> Chris
>>>>>
>>>>>
>>>>> On Wed, May 13, 2015 at 11:01:17AM -0400, Wayne Stambaugh wrote:
>>>>>> Chris,
>>>>>>
>>>>>> I just tested this and I like the changes. I believe I found a
>>>>>> bug. I
>>>>>> just rescued an old project and noticed all of the zener diodes were
>>>>>> oriented 180 degrees from the unrescued version. When you get a
>>>>>> chance,
>>>>>> would you please verify the component orientation against the rescued
>>>>>> library is correct. I'll commit this patch. If you find a bug,
>>>>>> please
>>>>>> apply the patch against this patch.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Wayne
>>>>>>
>>>>>> On 5/4/2015 1:30 PM, Chris Pavlina wrote:
>>>>>>> I've got two changes here - they're a bit inadvertently
>>>>>>> intertwined, so
>>>>>>> I left them as one patch, otherwise one would depend on the other
>>>>>>> anyway. Let me know if you want me to discard half.
>>>>>>>
>>>>>>> 1. Remove the summary dialog from lib-cache-rescue. I originally
>>>>>>> created
>>>>>>> it so the user would know what the new names of the components
>>>>>>> were; I
>>>>>>> compensated by changing the main dialog to display the suffix that
>>>>>>> will
>>>>>>> be added to the parts.
>>>>>>>
>>>>>>> 2. Minor bugfix: If no parts are rescued, an empty rescue library
>>>>>>> shouldn't be written.
>>>>>>>
>>>>>>> --
>>>>>>> Chris
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>> More help : https://help.launchpad.net/ListHelp
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>> More help : https://help.launchpad.net/ListHelp
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help : https://help.launchpad.net/ListHelp
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
Follow ups
References
-
[PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
From: Chris Pavlina, 2015-05-04
-
Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
From: Wayne Stambaugh, 2015-05-13
-
Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
From: Chris Pavlina, 2015-05-13
-
Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
From: Maciej Sumiński, 2015-05-13
-
Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
From: Wayne Stambaugh, 2015-05-13
-
Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
From: Chris Pavlina, 2015-05-13
-
Re: [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug
From: Wayne Stambaugh, 2015-05-13