| Thread Previous • Date Previous • Date Next • Thread Next |
Thanks, Orson, much appreciated. It looks like there a small nit in those changes due to a recent change in lp:kicad. The attached patch is needed to build against a patched wxWidgets.
Attachment:
wx_view_controls.cpp.patch
Description: Binary data
> On May 21, 2015, at 2:31 PM, Maciej Sumiński <maciej.suminski@xxxxxxx> wrote: > > Wayne agreed, so the patch has been committed in 5673. There is just one > reminder - please test the patch thoroughly before the stable release, > as later we will only backport patches that cause KiCad to crash. > > There were minor changes to fix code formatting. I updated the patch to > apply cleanly against wx 3.0.2 and applied the same trick as for the > Retina patch, so there is a #define that indicates presence of the patch. > > Adam, it looks like you may need to rebuild wxWidgets again, that is a > busy week. > > Regards, > Orson > > On 05/21/2015 09:32 PM, Adam Wolf wrote: >> I am in support of merging the pinch-to-zoom code in-especially now that >> zoom is nicer in GAL anyway! >> >> The other features that were more controversial were regarding the trackpad >> and "fine resolution scroll devices", and I have exhausted all brainpower >> regarding that until after the stable release :) >> >> Adam Wolf >> >> On Thu, May 21, 2015 at 2:24 PM, Garth Corral <gcorral@xxxxxxxxx> wrote: >> >>> >>> >>> Hi, Orson. This is not the controversial set of changes to which you >>> refer, it is only the subset that does pinch-to-zoom. >>> >>> It is 100% conditionally compiled so will be inert unless explicitly >>> compiled in, and will only compile/work on OS X. >>> >>> Garth >>> >>>> On May 21, 2015, at 12:13 PM, Maciej Sumiński <maciej.suminski@xxxxxxx> >>> wrote: >>>> >>>> Hi Garth, >>>> >>>> If I recall correctly there were issues on other platforms, but I guess >>>> it is not the case anymore, so if Wayne does not mind - I will merge >>>> them. Personally, I do not mind applying the patch if it does not break >>>> anything, especially if OS X users find it useful. >>>> >>>> I borrowed a Macbook only for a weekend to fix GAL issues, so I cannot >>>> test your patch now, but I trust our users. I would offer you to test >>>> patches on Linux/Windows, but I see that all changes are surrounded with >>>> #ifdefs, so I would not experience any difference anyway. >>>> >>>> Scrollbars are not a problem, as I did not manage to enable them for OS >>>> X in GAL canvas. >>>> >>>> Regards, >>>> Orson >>>> >>>>> On 05/21/2015 07:33 PM, Garth Corral wrote: >>>>> I’m not going to flog the dead trackpad horse again, but could we at >>> least get my pinch-to-zoom changes in? I committed this separately from >>> the rest of the stuff on my branch because it can stand on it’s own, and is >>> completely conditional so it won’t touch anything else. It might not be as >>> useful without the other stuff on the branch, but at least folks can >>> compile in proper pinch zooming for their Mac trackpads if they desire. >>>>> >>>>> Orson, if you want to try this out you can bzr merge -r 5239..5241 >>> lp:~gcorral/kicad/osx-trackpad-gestures into a trunk checkout. It >>> requires yet another wxWidgets patch, which is included in that diff. I >>> think there might be a conflict due to my disabling scrollbars on my >>> branch, but you can do as you wish with that. >>>>> >>>>> >>>>> Garth >>>>> >>>>> >>>>>> On May 18, 2015, at 5:09 AM, Maciej Sumiński <maciej.suminski@xxxxxxx> >>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I have just committed a patch that should fix the problem. Finally I >>> had >>>>>> an opportunity to play with a MacBook, and it resulted in two more >>>>>> changes for Macs: >>>>>> - Apple MagicMouse and trackpad should be now usable (no more crazy >>>>>> zooming in/out). >>>>>> - Full resolution support for Retina screens in OpenGL canvas. It is >>>>>> enabled using a patch for wxWidgets, so the library must be recompiled >>>>>> if you want to take advantage of this feature. I hope noone minds one >>>>>> extra patch for wx, since we have to use a custom build anyway. >>>>>> >>>>>> Patch to mute sounds after pressing a key (from Paulo H. Silva) needs >>>>>> some extra care, but it will be applied later as well. >>>>>> >>>>>> In other news: >>>>>> - Scrollbars (excluding OSX; sorry - wxWidgets has won again with its >>>>>> lack of consistency) >>>>>> - Trivial connection selection >>>>>> >>>>>> Regards, >>>>>> Orson >>>>>> >>>>>>> On 05/06/2015 09:55 PM, Andy Peters wrote: >>>>>>> Using Adam’s nightly OS X builds, most recently BZR 5645, pcbnew is >>> repeatedly crashing. It happens on both my 10.9 machine and my 10.10 >>> machine. In OpenGL mode, it seems to get confused about menus, or >>> something. It happens if I right-click to do something. I am not exactly >>> sure what conditions cause it. Attached is the relevant part of the bug >>> report: >>>>>>> >>>>>>> >>>>>>> Crashed Thread: 0 Dispatch queue: com.apple.main-thread >>>>>>> >>>>>>> Exception Type: EXC_CRASH (SIGABRT) >>>>>>> Exception Codes: 0x0000000000000000, 0x0000000000000000 >>>>>>> >>>>>>> Application Specific Information: >>>>>>> *** Terminating app due to uncaught exception >>> 'NSInternalInconsistencyException', reason: 'Menu to be set as submenu is >>> already a submenu of some menu.' >>>>>>> abort() called >>>>>>> terminating with uncaught exception of type NSException >>>>>>> >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>>> More help : https://help.launchpad.net/ListHelp >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Mailing list: https://launchpad.net/~kicad-developers >>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>>>> More help : https://help.launchpad.net/ListHelp >>>> >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
| Thread Previous • Date Previous • Date Next • Thread Next |
