kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

I originally didn't make lib-cache-rescue check pin names when testing whether a symbol has been modified, having in mind name changes that don't affect purpose (like VDD -> V+), but this caused a problem with the recent library change to swap diode pins around, as the numbers and positions never changed. Here's a quick patch to check the names too, so it'll pick up on A->K and fix diode symbols.

--
Chris

commit c2431899809769f2d0cd48d60c60b15c31a7deb9
Author: Chris Pavlina <cpavlin1@xxxxxxxxxxxxxx>
Date:   Sun May 24 11:10:01 2015 -0400

    Correct symbol rescue - check pin names too

diff --git a/eeschema/lib_cache_rescue.cpp b/eeschema/lib_cache_rescue.cpp
index 44c7c93..91a545d 100644
--- a/eeschema/lib_cache_rescue.cpp
+++ b/eeschema/lib_cache_rescue.cpp
@@ -219,7 +219,7 @@ static void find_rescues( std::vector<SCH_COMPONENT*>& aComponents, PART_LIBS* a
         // Test whether there is a conflict
         if( !cache_match || !lib_match )
             continue;
-        if( !cache_match->PinsConflictWith( *lib_match, /* aTestNums */ true, /* aTestNames */ false,
+        if( !cache_match->PinsConflictWith( *lib_match, /* aTestNums */ true, /* aTestNames */ true,
                 /* aTestType */ true, /* aTestOrientation */ true, /* aTestLength */ false ))
             continue;