← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix warning for some pads with no copper layer

 

Hi Chris,

Good point, thank you for the patch. It has been committed in revision 5682.

Regards,
Orson

On 05/26/2015 04:30 PM, Chris Pavlina wrote:
> D_PAD::ViewGetLayers tries to handle the case of a pad that exists only
> on mechanical layers, but misses a few (silkscreen, Dwgs.User,
> Eco1/2.User). Even if putting a pad on these layers is perhaps not the
> best idea, the footprint editor does allow it, so internal errors
> shouldn't be raised if you do it. Here's a patch that adds these layers
> to the list of layers examined.
> 
> Also restructures the code a bit, it was very much a WET - We Enjoy
> Typing! - design... made to loop over the list of layers.
> 
> It's still possible to get an invalid configuration if one were to
> hand-edit the file, so I also edited the error message that is displayed
> to make it perhaps a bit more helpful.
> 
> -- 
> Chris
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References