kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Chris,

I committed this patch with a minor change to make the exception message
a bit more understandable.

Thanks,

Wayne

On 6/7/2015 7:24 PM, Chris Pavlina wrote:
> If you try to load a kicad_pcb into pcbnew that refers to an invalid net 
> ID, pcbnew crashes after failing an assertion. It should display an 
> error indicating that the file is corrupt instead. I've changed 
> BOARD_CONNECTED_ITEM::SetNetCode() to be able to indicate whether the 
> code was valid, rather than just asserting, and then changed 
> PCB_PARSER::parseTRACK() to check for this and complain using 
> Expecting().
> 
> I'd rather have used an exception to do this, but we don't have any 
> exception types that look suitable. Thoughts?
> 
> Here's a board file that causes this: 
> http://misc.c4757p.com/2VB701E.kicad_pcb
> 
> --
> Chris
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>