← Back to team overview

kicad-developers team mailing list archive

[PATCH] Rescue error message not shown

 

There's a minor bug in lib_cache_rescue - if it fails to insert the new 
library into the project, the error message for this is not displayed. 
This patch adds the necessary ShowModal() call.

--
Chris
commit a2f938a9c25bf1273a9e7c8f8919a0e95b695ff3
Author: Chris Pavlina <cpavlin1@xxxxxxxxxxxxxx>
Date:   Sat Jun 13 16:41:49 2015 -0400

    Bugfix: rescue error message not shown

diff --git a/eeschema/lib_cache_rescue.cpp b/eeschema/lib_cache_rescue.cpp
index 91a545d..da74997 100644
--- a/eeschema/lib_cache_rescue.cpp
+++ b/eeschema/lib_cache_rescue.cpp
@@ -379,6 +379,7 @@ bool SCH_EDIT_FRAME::RescueCacheConflicts( bool aRunningOnDemand )
             rescue_log_item.component->SetPartName( rescue_log_item.old_name );
         }
         wxMessageDialog dlg( this, _( "An error occurred while attempting to rescue components. No changes have been made." ) );
+        dlg.ShowModal();
         return false;
     }
 }

Follow ups