← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix to closing polylines in DXF imports

 

Le 18/06/2015 16:29, Marco Hess a écrit :
> Following up on recent previous discussions and patches re. DXF import,
> here is a patch that fixes the problem of imported ellipses remaining an
> open shape.
> 
> The DXF format polylines and lwpolylines have a 'flags' field of which
> bit 0 indicates if the polyline/lwpolyline is to be closed or open. This
> flags field is correctly read during the import but in the conversion to
> board segments, was previously not used.
> 
> This patch remembers the start of the polyline and then after processing
> all segments it check bit 0
> of the flags field. If the bit is set to 1, an extra closing segment is
> generated between the last segment endpoint and the remembered polyline
> start point.
> 
> Also attached a ellipses DXF in R12 format exported from LibreCAD that I
> used to test this patch. It clearly shows the open segment when
> imported. With the patch in place the DXF imports correctly shows as a
> closed polyline.
> 
> Regards,
> 
> Marco

Patch committed. Thanks.


-- 
Jean-Pierre CHARRAS


References