kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Henner,

Good catch.  I'm not sure how this one slipped through the cracks.

I committed your patch in the product branch r5783.  I did have to fix
some coding policy issues (curly bracket placement).  Please keep that
in mind in future patches.

Thanks,

Wayne

On 6/18/2015 1:45 AM, Henner Zeller wrote:
> Hi,
> When using version control, I noticed that whenever I safe the file,
> almost every line changed, even if there are only tiny changes. This
> is very annoying, in particular with version control, as it is
> impossible to see what changed (also it makes it virtually impossible
> to merge changes manually).
> 
> Turns out the segments are alternating stored front to back, then back
> to front. Reason is that while reading the file, the BOARD::Add()
> function is called with ADD_APPEND by the PCB_PARSER, however, that
> flag is ignored.
> So each time in reading, the sequence of segments is turned upside down.
> 
> Patch attached.
> 
> Henner.
> 
> (that the API provides both at the flick of an integer value is
> probably something that should be changed to two different method
> names to make that more explicit; but that is a refactoring change
> after the release).
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>