kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Nice, I was just about to submit a second patch to fix that destructor. :)


On Mon, Jun 22, 2015 at 08:36:12PM +0200, jp charras wrote:
> Le 22/06/2015 20:17, Chris Pavlina a écrit :
> > Oh, wow. God, I'm a bloody idiot.
> > 
> > Third time's the charm?
> > 
> > 
> > On Mon, Jun 22, 2015 at 02:13:40PM -0400, Chris Pavlina wrote:
> >> Found the problem in the rescue update - left a couple unused variable 
> >> declarations behind, which were no longer valid. Not sure why clang was 
> >> okay with them, it shouldn't have been.
> >>
> >> --
> >> Chris
> 
> I committed your fix. Thanks.
> 
> To avoid a compil warning I also added a virtual destructor (which do
> nothing) in class RESCUE_CANDIDATE.
> 
> 
> -- 
> Jean-Pierre CHARRAS