← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix segfault on quit

 

Nope, looks like both patches are necessary. I'll investigate the first 
one further tonight, as that's just a workaround, but the second is 
definitely a fix.

On Mon, Jun 22, 2015 at 07:41:24PM -0400, Wayne Stambaugh wrote:
> Is this in addition to or instead of your previous patch that removed
> destroy() from ~PGM_BASE()?
> 
> On 6/22/2015 7:04 PM, Chris Pavlina wrote:
> > Under certain (but not all) conditions, kicad applications segfault on 
> > quit. This has been reported:
> > 
> > https://bugs.launchpad.net/kicad/+bug/1431028
> > https://bugs.launchpad.net/kicad/+bug/1467221
> > 
> > It appears to be the case that Pgm().OnPgmExit() was called in the wrong 
> > place. This patch moves it from APP_SINGLE_TOP::OnRun() to 
> > APP_SINGLE_TOP::OnExit(), which appears to correct the issue.
> > 
> > --
> > Chris
> > 
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References